[clang-tidy] Fix thread_local false positives in misc-use-internal-linkage check
#132573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) ChangesBased on C++ standard (see issue #131679) and StackOverflow However, many people still use Closes #131679. Full diff: https://github.com/llvm/llvm-project/pull/132573.diff 3 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp b/clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp
index a1a20c0782230..e2071b806b125 100644
--- a/clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp
@@ -130,7 +130,10 @@ void UseInternalLinkageCheck::registerMatchers(MatchFinder *Finder) {
isMain())))
.bind("fn"),
this);
- Finder->addMatcher(varDecl(Common, hasGlobalStorage()).bind("var"), this);
+ Finder->addMatcher(
+ varDecl(Common, hasGlobalStorage(), unless(hasThreadStorageDuration()))
+ .bind("var"),
+ this);
}
static constexpr StringRef Message =
diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst
index 72aa05eb4dcd1..816e3ea579817 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -164,7 +164,9 @@ Changes in existing checks
- Improved :doc:`misc-use-internal-linkage
<clang-tidy/checks/misc/use-internal-linkage>` check by fix false positives
- for function or variable in header file which contains macro expansion.
+ for function or variable in header file which contains macro expansion and
+ excluding variables with ``thread_local`` storage class specifier from being
+ matched.
- Improved :doc:`modernize-use-default-member-init
<clang-tidy/checks/modernize/use-default-member-init>` check by matching
diff --git a/clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-var.cpp b/clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-var.cpp
index 901272e40b8f2..3da05c71dd94f 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-var.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/misc/use-internal-linkage-var.cpp
@@ -31,6 +31,8 @@ extern int global_extern;
static int global_static;
+thread_local int global_thread_local;
+
namespace {
static int global_anonymous_ns;
namespace NS {
@@ -41,6 +43,7 @@ static int global_anonymous_ns;
static void f(int para) {
int local;
static int local_static;
+ thread_local int local_thread_local;
}
struct S {
|
Contributor
Author
|
@PiotrZSL, could you please merge this PR when you have time, thank you. |
HerrCai0907
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on C++ standard (see issue #131679) and StackOverflow
thread_localvariables are implicitlystaticso we should not suggest addingstaticon athread_localvariables. I'd appreciate if someone else will confirm this too because reading standard is tricky.However, many people still use
staticandthread_localtogether: github code-search. Maybe disabling warnings onthread_localshould be made as a flag? WDYT?Closes #131679.